Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove predicate functions - use filter_deployments() #316

Closed
5 of 6 tasks
damianooldoni opened this issue Jul 4, 2024 · 6 comments · Fixed by #321 or #331
Closed
5 of 6 tasks

Remove predicate functions - use filter_deployments() #316

damianooldoni opened this issue Jul 4, 2024 · 6 comments · Fixed by #321 or #331
Assignees
Milestone

Comments

@damianooldoni
Copy link
Member

damianooldoni commented Jul 4, 2024

Once #315 is completed, we can replace the predicates with filter functions. Here below the most important steps:

@damianooldoni damianooldoni changed the title Remove predicate functions Remove predicate functions - use filter_deployments() Jul 4, 2024
@damianooldoni damianooldoni added this to the v1.0 milestone Jul 4, 2024
@PietrH
Copy link
Member

PietrH commented Jul 4, 2024

Functions should not do any filtering at all internally, any filtering should happen before and be piped in.

So lines using predicates can just be removed.

@PietrH
Copy link
Member

PietrH commented Jul 4, 2024

We should make a new vignette about the filtering functions : how to read data, how to manipulate camtrapdp objects

@PietrH
Copy link
Member

PietrH commented Jul 4, 2024

There are still references to mica in my branch:

#' get_n_species(mica)

Probably should remove these, I don't want to do this in the same branch

@PietrH
Copy link
Member

PietrH commented Jul 4, 2024

I should also scan the package of the word filter in the documentation and examples, as well as keep an eye out for triple dots: ...

@PietrH PietrH linked a pull request Jul 4, 2024 that will close this issue
@PietrH PietrH closed this as completed Jul 5, 2024
@damianooldoni
Copy link
Member Author

Based on good practices, we must make these functions defunct, instead of just removing them.

@damianooldoni
Copy link
Member Author

Fixed by PR #331. The task of updating the vignette has been already transferred to a separate issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants