-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove predicate functions - use filter_deployments()
#316
Comments
filter_deployments()
Functions should not do any filtering at all internally, any filtering should happen before and be piped in. So lines using predicates can just be removed. |
We should make a new vignette about the filtering functions : how to read data, how to manipulate camtrapdp objects |
There are still references to Line 14 in a10adc1
Probably should remove these, I don't want to do this in the same branch |
I should also scan the package of the word |
Based on good practices, we must make these functions defunct, instead of just removing them. |
Fixed by PR #331. The task of updating the vignette has been already transferred to a separate issue. |
Once #315 is completed, we can replace the predicates with filter functions. Here below the most important steps:
Remove predicate related functionsUPDATE make predicate functions defunctNEWS.md
filter_deployments()
The text was updated successfully, but these errors were encountered: