download_zenodo(): use curl::multi_download() for parallel = TRUE; add unit tests #124
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hansvancalster Two errors from {checklist} should now be fixed (a linter and the package version). However the other two errors seem false positives to me.
|
hansvancalster
requested changes
Nov 21, 2023
There was a problem hiding this comment.
Thanks! I tested the new functionality and it works as expected!
I would however prefer a less stringent unit test that does not rely on a snapshot, but rather just check with expect_no_error() and expect_no_warning(). My comment below shows that snapshots may be a bit brittle.
I think you should run
If you remove the snapshot (as I suggest above) this will no longer be an issue. |
|
@hansvancalster I relaxed the unit tests as requested.
I'm using latest versions. I cannot reproduce the GHA checklist error locally. Output from
|
hansvancalster
approved these changes
Nov 21, 2023
|
Yes, but a next round will rewrite the Rd file to its checklist-incompatible state (although note that I don't get the error from checklist as in GHA): > checklist::check_documentation()
ℹ Updating inborutils documentation
ℹ Loading inborutils
Writing convertdf_enc.Rd |
Not on my machine... So something is different. I wonder if it has something to do with different way in capitalization on linux vs windows. The change in a8781bf is just changing 'a' to 'A'. |
I know 🙂 . |
|
Documentation mystery - could be just this:
Supposing the change in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This approach is faster than forking the R process, by using the libcurl facilities instead to do concurrent downloading of multiple files.
This PR also flips the default value for the
parallelargument fromFALSEtoTRUE.Also copying the unit tests from {n2khab} package in order to capture problems early-on.