Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new function locate_n2khab_data() for read functions #174

Merged
merged 9 commits into from
Nov 27, 2023

Conversation

florisvdh
Copy link
Member

This PR removes the usage of fileman_up("n2khab_data") in providing a default basepath for the read functions.

Instead, this role is replaced by a dedicated function locate_n2khab_data() that:

  • by default still largely does the same as fileman_up("n2khab_data"), but is not limited to the (default) 10 directory levels to search for the n2khab_data directory;
  • takes into account the n2khab_data_path option (or if missing, its corresponding environment variable N2KHAB_DATA_PATH). If set, and on condition this filepath exists, the option takes priority and no search is done.

@florisvdh florisvdh merged commit 51456d4 into dev_nextrelease Nov 27, 2023
3 checks passed
@florisvdh florisvdh deleted the n2khab_data branch November 27, 2023 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant