SSL Optional

[ghost]

will be good if you add some optional option like 'CURLOPT_SSL_VERIFYPEER', because when the url using SSL the curl will be error. Add 'curl_setopt ($ch, CURLOPT_SSL_VERIFYPEER, 0);' and boom work

[straube]

Hey @Diiedha! This is definitely not the safest path to fix SSL errors. Please refer to this article to learn why -- take a look at the Server-Side HTTPS Requests section.

And, in the end, if you really want to add that option, you can do it manually. Having it by default is not a good idea.

Unless you're suggesting it should support the -k option. Then it makes sense. In that case, you'd be required to add the option to command to have it in the PHP code.

[incarnate]

Thanks @straube - adding support for -k would provide a path for adding CURLOPT_SSL_VERIFYPEER.

However for reasons along the lines of what you have pointed out, I'm uncomfortable adding that flag since in most cases it isn't the right solution.

As a compromise maybe we could support -k but also stick a big warning on the line above.

// WARNING: Disabling certificate verification is insecure and not recommended
curl_setopt ($ch, CURLOPT_SSL_VERIFYPEER, 0);

[NabiKAZ]

I agree with detect -k