Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added --data-raw support #35

Merged
merged 7 commits into from
Oct 18, 2021
Merged

Added --data-raw support #35

merged 7 commits into from
Oct 18, 2021

Conversation

mkp95
Copy link
Contributor

@mkp95 mkp95 commented Dec 4, 2020

Raw data support

@incarnate
Copy link
Owner

Hi @mkp95 - happy new year and thanks for the pull request!

Can you please narrow the changes to just the support for --data-raw - I'm uncomfortable with disabling HTTPS verification as a default. See #5 for more discussion on that.

@NabiKAZ
Copy link
Contributor

NabiKAZ commented Mar 6, 2021

@mkp95
@incarnate said correct, please remove detect https from your code. I need just data-row support for now.
It's been about 3 months; Can you do that or think of something else?

@mkp95
Copy link
Contributor Author

mkp95 commented Mar 29, 2021

@mkp95
@incarnate said correct, please remove detect https from your code. I need just data-row support for now.
It's been about 3 months; Can you do that or think of something else?

I think I have to edit the whole file again will do it by 1st April..

@mkp95
Copy link
Contributor Author

mkp95 commented Mar 31, 2021

now you can approve the pull request .. i removed all alterations and added data raw support only

@@ -261,10 +261,10 @@ function curlToPHP(curl) {
loadData(cmd.d);
if (cmd.data)
loadData(cmd.data);
if (cmd['data-raw'])
loadData(cmd['data-raw']);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

data raw added

@NabiKAZ
Copy link
Contributor

NabiKAZ commented May 11, 2021

@incarnate

@NabiKAZ NabiKAZ mentioned this pull request May 18, 2021
@incarnate incarnate merged commit 59926ab into incarnate:gh-pages Oct 18, 2021
@incarnate
Copy link
Owner

Apologies for the slow merge, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants