This repository has been archived by the owner on Nov 22, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 10
Feat/add payment gateway resources #74
Merged
incentrotolgaakyazi
merged 36 commits into
main
from
feat/add_payment_gateway_resources
Jan 11, 2023
Merged
Feat/add payment gateway resources #74
incentrotolgaakyazi
merged 36 commits into
main
from
feat/add_payment_gateway_resources
Jan 11, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…not being allowed in 'test-mode'.
…not being allowed in 'test-mode'.
# Conflicts: # commercelayer/provider.go # commercelayer/types.go
demeyerthom
suggested changes
Jan 11, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very nice! Some other general things:
- Can you also update the docs? Should be a command in the Makefile
- Can you update the README also? We have a checklist of implemented resources, so we can also check these!
examples/resources/commercelayer_checkout_com_gateway/resource.tf
Outdated
Show resolved
Hide resolved
examples/resources/commercelayer_checkout_com_gateway/resource.tf
Outdated
Show resolved
Hide resolved
demeyerthom
previously approved these changes
Jan 11, 2023
demeyerthom
approved these changes
Jan 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.