Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Exception while rendering recommendations #4476

Closed
reckart opened this issue Jan 28, 2024 · 0 comments
Closed

Exception while rendering recommendations #4476

reckart opened this issue Jan 28, 2024 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Recommender
Milestone
30.4

Comments

@reckart
Copy link
Member

reckart commented Jan 28, 2024

Describe the bug
There can be an exception in the OverlapIterator while rendering recommendations.

To Reproduce
Unclear - found in logs.

Expected behavior
No exception.

Screenshots

java.lang.NullPointerException: Cannot invoke "de.tudarmstadt.ukp.inception.recommendation.api.model.Offset.getEnd()" because "this.a" is null
	at de.tudarmstadt.ukp.inception.recommendation.util.OverlapIterator.stepB(OverlapIterator.java:94)
	at de.tudarmstadt.ukp.inception.recommendation.util.OverlapIterator.step(OverlapIterator.java:112)
	at de.tudarmstadt.ukp.inception.recommendation.util.OverlapIterator.<init>(OverlapIterator.java:57)
	at de.tudarmstadt.ukp.inception.recommendation.service.RecommendationServiceImpl.hideSpanSuggestionsThatOverlapWithAnnotations(RecommendationServiceImpl.java:2366)

Please complete the following information:

  • Version and build ID: 30.0
@reckart reckart added 🐛Bug Something isn't working Module: Recommender labels Jan 28, 2024
@reckart reckart added this to the 30.4 milestone Jan 28, 2024
@reckart reckart self-assigned this Jan 28, 2024
reckart added a commit that referenced this issue Jan 28, 2024
@reckart
#4476 - Exception while rendering recommendations
20f8e24 
- If a is already null, no need to try and comparing against its end position
reckart added a commit that referenced this issue Jan 28, 2024
@reckart
Merge pull request #4477 from inception-project/bugfix/4476-Exception…
c9baef6 
…-while-rendering-recommendations

#4476 - Exception while rendering recommendations
@reckart reckart closed this as completed Jan 28, 2024
reckart added a commit that referenced this issue Jan 28, 2024
@reckart
Merge branch 'release/30.x'
748b918 
* release/30.x:
  #4476 - Exception while rendering recommendations
reckart added a commit that referenced this issue Jan 28, 2024
@reckart
Merge branch 'main' into feature/4472-Better-built-in-layer-selection
17ffa7e 
* main:
  #4476 - Exception while rendering recommendations
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Recommender
Projects
Kanban
Archived in project
Milestone
30.4
Development

No branches or pull requests
1 participant
@reckart