Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error marker on annotations with required concept feature is missing #4484

Closed
reckart opened this issue Jan 30, 2024 · 0 comments
Closed

Error marker on annotations with required concept feature is missing #4484

reckart opened this issue Jan 30, 2024 · 0 comments
Assignees
@reckart
Labels
🐛Bug Something isn't working Module: Entity Linking
Milestone
30.4

Comments

@reckart
Copy link
Member

reckart commented Jan 30, 2024

Describe the bug
When a concept feature is mandatory, but the feature is not filled in, a error marker should be rendered - just as with mandatory string features.

To Reproduce
Steps to reproduce the behavior:

  1. Create project from entity linking template.
  2. Make the identifier feature required in the feature settings
  3. Create a named entity annotation
  4. See that the annotation does not bear an error marker

Expected behavior
In the brat editor, the annotation should have a red glow.

Please complete the following information:

  • Version and build ID: 30.3

Additional context
Add any other context about the problem here.
@reckart reckart added 🐛Bug Something isn't working Module: Entity Linking labels Jan 30, 2024
@reckart reckart added this to the 30.4 milestone Jan 30, 2024
@reckart reckart self-assigned this Jan 30, 2024
reckart added a commit that referenced this issue Jan 30, 2024
@reckart
#4484 - Error marker on annotations with required concept feature is …
d1a2652 
…missing

- Generate error comment for required features for "virtual" features as well
reckart added a commit that referenced this issue Jan 30, 2024
@reckart
Merge pull request #4485 from inception-project/bugfix/4484-Error-mar…
1a2b3ab 
…ker-on-annotations-with-required-concept-feature-is-missing

#4484 - Error marker on annotations with required concept feature is missing
@reckart reckart closed this as completed Jan 30, 2024
reckart added a commit that referenced this issue Jan 30, 2024
@reckart
Merge branch 'release/30.x'
ee63617 
* release/30.x:
  #4484 - Error marker on annotations with required concept feature is missing
reckart added a commit that referenced this issue Jan 30, 2024
@reckart
Merge branch 'main' into feature/4472-Better-built-in-layer-selection
660dd31 
* main:
  [maven-release-plugin] prepare for next development iteration
  [maven-release-plugin] prepare release inception-30.4
  #4379 - Suppress or mark concepts in the search that are marked as owl:deprecated
  #4484 - Error marker on annotations with required concept feature is missing
  #4480 - Show validation problems in annotation sidebar and Apache Annotator editor
  #4482 - Error when fetching state of background tasks from UI
  #4478 - Some external editor configuration properties cannot be configured
@reckart reckart added this to Kanban Aug 7, 2024
@reckart reckart moved this to 🍹 Done in Kanban Aug 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@reckart reckart

Labels
🐛Bug Something isn't working Module: Entity Linking
Projects
Kanban
Archived in project
Milestone
30.4
Development

No branches or pull requests
1 participant
@reckart