#4523 - Factor endpoint-specific FTS code out into adapter classes #4524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Started by factoring out the "withLabelMatchingExactlyAnyOf" calls
- Factoring out the "withLabelContainingAnyOf" calls
- Factor out the remaining calls - Start trying to separate adapter classes from query builder
reckart
force-pushed
the
refactoring/4523-Factor-endpoint-specific-FTS-code-out-into-adapter-classes
branch
2 times, most recently
from
20c9293 to
014e7dd
Compare
- Extract FTS adapter classes from query builder
reckart
force-pushed
the
refactoring/4523-Factor-endpoint-specific-FTS-code-out-into-adapter-classes
branch
from
014e7dd to
0ad9b32
Compare
- Further disentangle test code
reckart
deleted the
refactoring/4523-Factor-endpoint-specific-FTS-code-out-into-adapter-classes
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in the PR
How to test manually
Automatic testing
Documentation