Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#4530 - Keyboard shortcuts for feature values may not work in certain editors #4531

Merged
merged 1 commit into from
Feb 20, 2024
Merged

#4530 - Keyboard shortcuts for feature values may not work in certain editors #4531

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions inception/inception-external-editor/src/main/ts/src/ExternalEditorFactory.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -107,17 +107,20 @@ export class ExternalEditorFactory implements AnnotationEditorFactory {
if (source !== target) {
source.addEventListener('keydown', event => {
console.debug(`Forwarding keydown event: ${event.key}`)
target.document.dispatchEvent(new KeyboardEvent('keydown', event))
const delegate = target.document.body || target.document
delegate.dispatchEvent(new KeyboardEvent('keydown', event))
})

source.addEventListener('keyup', event => {
console.debug(`Forwarding keyup event: ${event.key}`)
target.document.dispatchEvent(new KeyboardEvent('keyup', event))
const delegate = target.document.body || target.document
delegate.dispatchEvent(new KeyboardEvent('keyup', event))
})

source.addEventListener('keypress', event => {
console.debug(`Forwarding keypress event: ${event.key}`)
target.document.dispatchEvent(new KeyboardEvent('kekeypressyup', event))
const delegate = target.document.body || target.document
delegate.dispatchEvent(new KeyboardEvent('kekeypressyup', event))
})
}

Expand Down
Loading