Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Peaks and Statistic maps reader #12

Merged
merged 5 commits into from
Feb 3, 2016
Merged

Conversation

cmaumet
Copy link
Member

@cmaumet cmaumet commented Nov 2, 2015

This PR is work-in-progress to provide reading of NIDM-Results documents and export a list of peaks as a data frame.

@vsoch: here is some preliminary work I did following the comments you provided at the Chicago meeting. This first function export the peaks as a data frame. More columns could be added depending on the application and this could also be extended to other objects in the model (contrasts...).

Before going further, I just wanted to check if this can be of interest for your application...

@vsoch
Copy link
Member

vsoch commented Nov 2, 2015

This would be useful, but it would be best to have as a query in nidm-query - it's getting confusing having in both places. Is this the same as the PR you did to nidm-query?

@cmaumet
Copy link
Member Author

cmaumet commented Nov 2, 2015

This is a variant of the PR I did to nidm-query and is also based on our original peak query.

@cmaumet
Copy link
Member Author

cmaumet commented Nov 2, 2015

Part of this was written on my way back from Chicago. But, before going further, I would like to be sure this does not duplicate your work on nidm-query...

@cmaumet cmaumet changed the title Peaks reader Peaks and Statistic maps reader Feb 1, 2016
@cmaumet
Copy link
Member Author

cmaumet commented Feb 3, 2016

As discussed in #16, this PR creates peak and statistic map objects from a NIDM-Results document. An example of usage can be found in the nidmreader script.

@cmaumet
Copy link
Member Author

cmaumet commented Feb 3, 2016

I am going to merge this one so that PR in progress (update to NIDM-Results 1.2.0) can include it.

cmaumet pushed a commit that referenced this pull request Feb 3, 2016
Peaks and Statistic maps reader
@cmaumet cmaumet merged commit 52fb0e8 into incf-nidash:master Feb 3, 2016
@cmaumet cmaumet deleted the reader branch February 3, 2016 12:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants