Remove prefix from Go 1.21+ function names #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is explained in the code and comments. In Go 1.21+ the function name produced by runtime.Frame now includes – for functions created as a closure and called from a package – a prefix of the code that originally created that function. This causes real issues with error grouping, particularly when you consider the standard pattern of building Go HTTP servers with several middleware functions.
|
I'm going to merge this into our fork and ask upstream if this makes sense/they have other recommendations. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is explained in the code and comments.
In Go 1.21+ the function name produced by runtime.Frame now includes – for functions created as a closure and called from a package – a prefix of the code that originally created that function.
This causes real issues with error grouping, particularly when you consider the standard pattern of building Go HTTP servers with several middleware functions.