Fix xwayland fullscreen crash (#135)

Introduces a trivial fix for a crash in xwayland that could be triggered when a view with NULL size hints tried to go fullscreen
inclement · Sep 17, 2023 · 1ffa436 · 1ffa436
1 parent 586e3b8
commit 1ffa436
Showing 1 changed file with 13 additions and 10 deletions.
diff --git a/src/viv_xwayland_shell.c b/src/viv_xwayland_shell.c
@@ -369,17 +369,20 @@ static void implementation_grow_and_center_fullscreen(struct viv_view *view) {
     }
 
     int width = output->wlr_output->width;
-    if ((hints->max_width > 0) && ((int) hints->max_width < width)) {
-        width = hints->max_width;
-    } else if ((hints->min_width > 0) && ((int) hints->min_width > width)) {
-        width = hints->min_width;
-    }
-
     int height = output->wlr_output->height;
-    if ((hints->max_height > 0) && ((int) hints->max_height < height)) {
-        height = hints->max_height;
-    } else if ((hints->min_height > 0) && ((int) hints->min_height > height)) {
-        height = hints->min_height;
+
+    if (hints) {
+        if ((hints->max_width > 0) && ((int) hints->max_width < width)) {
+            width = hints->max_width;
+        } else if ((hints->min_width > 0) && ((int) hints->min_width > width)) {
+            width = hints->min_width;
+        }
+
+        if ((hints->max_height > 0) && ((int) hints->max_height < height)) {
+            height = hints->max_height;
+        } else if ((hints->min_height > 0) && ((int) hints->min_height > height)) {
+            height = hints->min_height;
+        }
     }
 
     int x = (output->wlr_output->width - width) / 2;