Use wlroots scene graph #133
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is just the very basics, it doesn't even remove the existing surface damage tracking and rendering pathways.
This is a lot of code! It used to be necessary to handle all the damage tracking. This leaves rendering broken for non-xdg views and for xdg popups etc. as that isn't implemented with wlr_scene yet, but since wlr_scene clearly is suitable for use it's easier to drop the baggage before adding back in the wlr_scene version of the functionality.
This reverts commit f318b01.
This replaces previous damage-based method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements #130. (Hopefully) fixes the rendering issues exposed in vivarium by the latest wlroots by switching to the scene_graph api instead of using our own damage tracking.
This is a relatively big change, but the scene_graph api is fairly straightforward and vivarium doesn't try to do anything special that needs extra treatment so hopefully isn't a big issue.