Non conan, filter SeaBIOS control chars, detect reboots #24

alfreb · 2024-05-25T18:25:36Z

Add requirements.txt and non-conan instructions
Add more error handling, especially for missing chainloader
Make grubify produce images at cwd, not next to binary, to allow direct boot of nix read-only binaries.
Filter out terminal control characters from SeaBIOS, which prevents us from detecting reboots
- This has the nice side-effect of making your terminal not broken after running qemu
Detect and warn about reboots

Important when we use nix that produces read only results.

In the past someone did a security review of IncludeOS and pointed to vmrunner as a major attack vector - we should have sent them this memo.

alfreb · 2024-05-26T11:33:31Z

For the SeaBIOS output, Zephyr had a bug about this as well:
zephyrproject-rtos/zephyr#11717

To fail more gracefully when the bridge is not there or when qemu fails to start for some other reason.

MagnusS

LGTM!

README.md

alfreb added 9 commits May 25, 2024 20:17

grubify: create image in cwd, not next to binary

a1c604a

Important when we use nix that produces read only results.

boot: More error handling, expect grub image at cwd

1fcdd64

vmrunner: error out if no chainloader found

d1df0e0

Update readme for workflow without conan, add requirements.py

b5bf7a0

boot: More error handling, expect grub image at cwd

800e09b

Update README.md with testing and development disclaimer.

5534810

In the past someone did a security review of IncludeOS and pointed to vmrunner as a major attack vector - we should have sent them this memo.

Mention file extension, make <boot> tag wider, matching <vmrunner>

98a65fd

Remove unused import

e6e5bfe

Filter out SeaBIOS control chars, detect reboots

1a8cfa1

alfreb changed the title ~~Non conan~~ Non conan, filter SeaBIOS control chars, detect reboots May 26, 2024

alfreb added 3 commits May 27, 2024 05:32

More explicit SeaBIOS check, Don't warn on Ctrl+c

c6303a0

Check for _proc before polling.

14c209c

To fail more gracefully when the bridge is not there or when qemu fails to start for some other reason.

Update readme with pythonpath

684084c

MagnusS approved these changes Jun 7, 2024

View reviewed changes

README.md Outdated Show resolved Hide resolved

Update README.md

29eb410

alfreb merged commit 11ac338 into master Jun 8, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Non conan, filter SeaBIOS control chars, detect reboots #24

Non conan, filter SeaBIOS control chars, detect reboots #24

alfreb commented May 25, 2024 •

edited

Loading

alfreb commented May 26, 2024

MagnusS left a comment

Non conan, filter SeaBIOS control chars, detect reboots #24

Non conan, filter SeaBIOS control chars, detect reboots #24

Conversation

alfreb commented May 25, 2024 • edited Loading

alfreb commented May 26, 2024

MagnusS left a comment

Choose a reason for hiding this comment

alfreb commented May 25, 2024 •

edited

Loading