Skip to content

Bump actions/setup-node from 3 to 4 in /actions/publish #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 16, 2023
+1 −1
Merged

Bump actions/setup-node from 3 to 4 in /actions/publish #76

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion actions/publish/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ inputs:
runs:
using: "composite"
steps:
- uses: actions/setup-node@v3
- uses: actions/setup-node@v4
with:
node-version: "18.16.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

📝
actions/setup-node@v4ではデフォルトでnodeのv20が使用されている。
バージョンを指定して、デグレさせた場合不具合が起きる可能性もあるので調査する必要がありそう。

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Basic

steps:
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
  with:
    node-version: 18
- run: npm ci
- run: npm test

Examples:

Major versions: 14, 16, 18

nodeバージョン18はサポートされている。

setup-nodeは指定されたバージョンのNode.jsをインストールするためのアクションだから、
アクションそのもののバージョンが20になってもインストール先としてサポートしていれば良さそう。

ref:https://github.com/actions/setup-node

- name: Install qiita-cli
Expand Down