Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[breaking change]Fix wrong API names GetDataObjects #186

Closed
longquanzheng opened this issue Jul 14, 2023 · 3 comments
Closed

[breaking change]Fix wrong API names GetDataObjects #186

longquanzheng opened this issue Jul 14, 2023 · 3 comments
Assignees
@zklgame
Labels
enhancement New feature or request small

Comments

@longquanzheng
Copy link
Contributor

As part of the major version upgrade, the name should be changed to GetDataAttributes...

https://github.com/indeedeng/iwf-java-sdk/releases/tag/v2.0.0

Now we have to make another breaking changes 🤦
@longquanzheng longquanzheng added enhancement New feature or request small labels Jul 14, 2023
@longquanzheng longquanzheng changed the title Fix wrong API names GetDataObjects [breaking change]Fix wrong API names GetDataObjects Jul 14, 2023
@longquanzheng longquanzheng mentioned this issue Jul 14, 2023
Merged
@zklgame zklgame self-assigned this Jul 18, 2023
@zklgame
Copy link
Contributor

zklgame commented Jul 18, 2023 •
edited
Loading

Should we rename in the sdk-idl now?
https://github.com/indeedeng/iwf-idl/pull/44/files

@longquanzheng
Copy link
Contributor Author

Should we rename in the sdk-idl now? https://github.com/indeedeng/iwf-idl/pull/44/files

That will be too much to do for this ticket, related to a lot of change in public repo and internal repos. We could do that in the future

@zklgame
Copy link
Contributor

zklgame commented Jul 19, 2023

in #189

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zklgame zklgame

Labels
enhancement New feature or request small
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@longquanzheng @zklgame