Support weak typed data attributes, and rename related methods #189
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zklgame
force-pushed
the
zklgame/support_weak_typed_attributes
branch
from
b64802a
to
5177e98
Compare
Codecov Report
@@ Coverage Diff @@
## main #189 +/- ##
============================================
+ Coverage 69.37% 69.99% +0.61%
- Complexity 349 355 +6
============================================
Files 58 59 +1
Lines 1476 1513 +37
Branches 134 135 +1
============================================
+ Hits 1024 1059 +35
- Misses 379 381 +2
Partials 73 73
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
longquanzheng
approved these changes
Jul 19, 2023
| dataAttributeField.getDataAttributeType()) | ||
| ); | ||
| for (final DataAttributeDef dataAttributeField : fields) { | ||
| if (!dataAttributeField.isPrefix()) { |
There was a problem hiding this comment.
Nit: swap the order of the if-else will make it slightly better to read:
if (dataAttributeField.isPrefix()) {
else {}
| .build(); | ||
| } | ||
|
|
||
| public static DataAttributeDef createByPrefix(final Class dataType, final String key) { |
There was a problem hiding this comment.
nit: key ==> keyPrefix
Also it will better to provide some comments to it. As it's not straightforward to know why this is needed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This MR did: