add-query-workflow-support #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duoertai
commented
Oct 14, 2022
src/main/java/io/github/cadenceoss/iwf/core/attributes/QueryAttributesRWImpl.java
Show resolved
Hide resolved
src/main/java/io/github/cadenceoss/iwf/core/attributes/QueryAttributesRWImpl.java
Show resolved
Hide resolved
longquanzheng
approved these changes
Oct 16, 2022
| final String wfType = workflowClass.getSimpleName(); | ||
| if (registry.getWorkflow(wfType) == null) { | ||
| throw new RuntimeException( | ||
| String.format("Workflow %s is not registered", wfType) |
There was a problem hiding this comment.
It will be great to throw different exception exceptions based on input error, workflow error or internal error: #42
But we can also improve in a separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.