fix workflow start options #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
duoertai
commented
Nov 16, 2022
| @@ -11,21 +11,16 @@ public static WorkflowStartOptions.WorkflowIDReusePolicyEnum toGenerated( | |||
| return WorkflowStartOptions.WorkflowIDReusePolicyEnum.ALLOW_DUPLICATE_FAILED_ONLY; | |||
| } | |||
| switch (workflowIdReusePolicy) { | |||
| case ALLOW_DUPLICATE_FAILED_ONLY -> { | |||
| case ALLOW_DUPLICATE_FAILED_ONLY: | |||
There was a problem hiding this comment.
to be compatible with java 8
longquanzheng
approved these changes
Nov 16, 2022
| @Value.Immutable | ||
| public abstract class WorkflowStartOptions { | ||
| public abstract Integer getWorkflowTimeoutSeconds(); | ||
|
|
||
| @Nullable |
There was a problem hiding this comment.
actually, how about let's use Optional, because:
- we are using it already so it's better to keep consistent
- Optional is more explicit and friendly IMO for caller to know this field could be null
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tested with cron schedule
tested with different workflow reuse id policy