Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only namespace top-level elements #5

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

jakub-id
Copy link
Contributor

don't do this for nested structs that inherit namespace from the parent. One could exclude all hoisted types but nested element defintions are seldom used in schemas.

don't do this for nested structs that inherit namespace from the parent.
One could exclude all hoisted types but nested element defintions are seldom used in schemas.
Copy link
Contributor

@adamdickmeiss adamdickmeiss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would have been with a test illustrating this

@jakub-id
Copy link
Contributor Author

@adamdickmeiss this actually changes previous behavior so one of the tests is updated.

@jakub-id jakub-id merged commit b878e4e into main Feb 20, 2025
1 check passed
@jakub-id jakub-id deleted the namespace-only-top-level branch February 20, 2025 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants