Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EMX: Add CCPA Suport #147

Merged
merged 3 commits into from
Feb 28, 2020
Merged

EMX: Add CCPA Suport #147

merged 3 commits into from
Feb 28, 2020

Conversation

ncolletti
Copy link
Contributor

Type of Change

  • New adapter
  • Feature Update
  • Bug Fix
  • Code Refactor
  • Other

Description of Change

Add US CCPA Support to Adapter

@ncolletti
Copy link
Contributor Author

FYI, we are not seeing the usp property of ComplianceService defined.

@jas-singh
Copy link
Contributor

jas-singh commented Jan 9, 2020 •
edited
Loading

@ncolletti

That is expected in the dev environment provided by the Adapter Development Suite (ADS).

In production, however, usp property will always be available if publisher has enabled IX library's privacy features (which can be determined by querying ComplianceService.isPrivacyEnabled() in the adapter). Additionally, the uspString property of the object retrieved from ComplianceService.usp.getConsent() will always exist as well. Please note the uspString property will be set as an empty string in the scenarios where the IX Library is not able to retrieve consent/opt-out from the site's page

ix-certification
ix-certification reviewed Feb 18, 2020
View reviewed changes
emx-digital/emx-digital-htb.js
@@ -151,7 +152,7 @@ function BRealTimeHtb(configs) {
}
};

if (gdprPrivacyEnabled) {
if (privacyEnabled) {
/* eslint-disable camelcase */
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove all lint disables, and fix the linting issues ...

@ix-certification ix-certification changed the base branch from canary to master February 28, 2020 16:48
@ix-certification ix-certification merged commit b5add47 into indexexchange:master Feb 28, 2020
ix-certification added a commit that referenced this pull request Feb 28, 2020
@ix-certification @ncolletti
EMX: Add CCPA Suport (#147) (#172)
1967ee4 
* Add US CCPA Support

* fix tests

* target ccpa string

Co-authored-by: Nicholas Colletti <34142758+ncolletti@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jas-singh jas-singh jas-singh left review comments

@ix-certification ix-certification ix-certification left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ncolletti @jas-singh @ix-certification