HTP-131 Consumable: CCPA/GDPR Consent Support #187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ix-certification
approved these changes
Sep 10, 2020
|
Hi @djcsdy - IX is currently running this update in our canary branch but we are not able to confirm if your CCPA update is working as expected, as calls to your adapter have not returned any demand during canary testing. Can you please let IX know how you'd like to proceed? Feel free to DM me with questions or concerns. Thanks! |
|
Please push to main. Thank you. |
andrew-a-dev
pushed a commit
to voxmedia/ix-library-adapters
that referenced
this pull request
Mar 9, 2021
* Import Consumable adapter from external repository. https://github.com/indexexchange/consumable-adapter/ * consumable: Use Utilities.isNumber in preference to typeof operator. * consumable: Add missing 'unitId' and 'unitName' parameters to bid request. * consumable: Implement CCPA compliance. * consumable: Implement GDPR compliance. * consumable: Expect GDPR compliance information to be present in the bid request. * consumable: Update documentation: Consumable supports consent now. * consumable: Correct documentation of bid requests. * consumable: Correct configuration documentation. * consumable: Update version number and changelog.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description of Change
It looks like all the other adapters are gradually moving into the ix-library-adapters repository, so I moved the Consumable adapter from its existing separate repository. I’m not sure if this was the right thing to do. The original adapter was at https://github.com/indexexchange/consumable-adapter. Let me know if I should raise a PR against the original adapter instead.
This change is the main purpose of this update.
Minor changes to bring the Index Exchange adapter in line with other adapters. This should not make any difference to bids at the moment, but might matter in future.
Additional minor corrections to the existing documentation.