Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HTP-0001] 33Across Adapter: Fix Validation #206

Merged
merged 5 commits into from
Oct 6, 2020

Conversation

terryc33x
Copy link
Contributor

Type of Change

  • New adapter
  • Feature Update
  • Bug Fix
  • Code Refactor
  • Other

Description of Change

Fix the SiteID validation

@ix-certification
Copy link
Contributor

Hi @terryc33x , can you confirm if you'd like this pushed to canary or master?

@terryc33x
Copy link
Contributor Author

Hi @terryc33x , can you confirm if you'd like this pushed to canary or master?

Thanks IX team, this is minor change, i will update the target branch from Canary to Master

@terryc33x terryc33x changed the base branch from canary to master September 16, 2020 22:50
@terryc33x
Copy link
Contributor Author

@ix-certification let me know if merging to master is not correct.

@ix-certification ix-certification merged commit 3fdfa5d into indexexchange:master Oct 6, 2020
ix-certification added a commit that referenced this pull request Oct 6, 2020
* fix the site id validation

* update changelog

* update the adapter version

Co-authored-by: terryc33x <64039851+terryc33x@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants