Make with_hasher const #203
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cuviper
reviewed
Sep 16, 2021
src/map.rs
Outdated
| @@ -179,8 +176,11 @@ impl<K, V, S> IndexMap<K, V, S> { | |||
| } | |||
|
|
|||
| /// Create a new map with `hash_builder` | |||
There was a problem hiding this comment.
Can you add a note about the constness, and that (like new) it does not allocate?
(ditto on the set)
There was a problem hiding this comment.
Done. I also noted ahash in particular because not many hash builders are const-able.
bluss
reviewed
Sep 18, 2021
src/map.rs
Outdated
Comment on lines
182
to
183
| /// If you need `hash_builder` that can be made in the static context, | ||
| /// consider [`ahash`](https://docs.rs/ahash/0.7.4/ahash/struct.RandomState.html#method.with_seeds). |
There was a problem hiding this comment.
it's nice to help the user but I'd like to avoid having such versioned urls - they are stale quickly - and fast-changing information - here. I would suggest we skip mentioning Ahash. The PR description is a good place for this info.
cuviper
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #202
If you need
hash_builderthat can be made in the static context, considerahash.