-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store JSON-LD parse errors #25
base: master
Are you sure you want to change the base?
Conversation
Web Auto Extractor logs and skips parse errors it encounters when working on JSON+LD. However, a program cannot react to messages written to console. This change allows a developer to hook into parse errors and react to them if desired. Fix indix#24
Interesting note about the failing tests: Travis runs tests against node v5.12. I wrote this code against v10.12. It appears Node has different error messages:
I have a couple ideas, and I'm interested in your take:
|
Node produces different error messages for JSON parse errors depending on the node.js version (Travis is pinned on an old Node version). This makes the tests future-proof.
@TheDahv who can merge this branch? |
@floflock I don't know. I haven't been in contact with anyone from Indix. |
@floflock oh I just read the other thread. Sounds like he wants us to work from a fork. In that case, we have 2 options:
I suppose it comes down to which of the two of us wants to become a maintainer :/ |
@TheDahv it is up to you. :) In my opinion, there is more to do: new esm syntax or typescript, more test cases, ... |
Is there a more actively maintained similar library? |
I've made a fork and merged the changes from some of the other forks: https://github.com/raine/web-auto-extractor Published as |
Web Auto Extractor logs and skips parse errors it encounters when
working on JSON+LD. However, a program cannot react to messages written
to console.
This change allows a developer to hook into parse errors and react to
them if desired.
Fix #24