Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing Arc crash #9

Merged
merged 1 commit into from
Feb 27, 2013
Merged

Fixing Arc crash #9

merged 1 commit into from
Feb 27, 2013

Conversation

thibaut-jarosz
Copy link
Contributor

The crash only occurs then using ARC and no animation, and if you do not keep any reference to the INPopoverController.

@indragiek
Copy link
Owner

I think the delegate should be set to nil in -animationDidStop:finished. Apple discourages the use of -performSelector: under ARC.

@thibaut-jarosz
Copy link
Contributor Author

The crash occurs when there is no animation. OS X tries to access the window, but it has been deallocated when setting the delegate to nil.

indragiek added a commit that referenced this pull request Feb 27, 2013
@indragiek indragiek merged commit 22ce1b9 into indragiek:master Feb 27, 2013
indragiek added a commit that referenced this pull request Dec 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants