Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make ObjTagged persistent hashable #571

Merged
merged 4 commits into from
Mar 11, 2022
Merged

Make ObjTagged persistent hashable #571

merged 4 commits into from
Mar 11, 2022

Conversation

kaushikcfd
Copy link
Collaborator

No description provided.

@inducer inducer enabled auto-merge (rebase) March 11, 2022 00:29
@inducer
Copy link
Owner

inducer commented Mar 11, 2022

Thx!

@kaushikcfd
Copy link
Collaborator Author

kaushikcfd commented Mar 11, 2022

Looks like the "examples CI" is picking the wrong python. Taking a look why that's happening.

@inducer
Copy link
Owner

inducer commented Mar 11, 2022

This happened in #569, too, but then stopped happening. I'm very confused by it.

@kaushikcfd
Copy link
Collaborator Author

I'm very confused by it.

The log says it does python3 -m pip install --editable . and says that "setup.py develop for loopy succeeded" but then doing python3 matmul-driver.py it says it cannot find loopy ❓ 😕.

@kaushikcfd
Copy link
Collaborator Author

After it installs loopy the conda install downgrades the python version:

2022-03-11T00:27:11.4897435Z The following packages will be DOWNGRADED:
2022-03-11T00:27:11.4897699Z 
2022-03-11T00:27:11.4897963Z   islpy                            2022.1.1-py310hcdad815_0 --> 2022.1.1-py37h3f5b68a_0
2022-03-11T00:27:11.4898397Z   markupsafe                          2.1.0-py310h5764c6d_1 --> 2.1.0-py37h0313132_1
2022-03-11T00:27:11.4898809Z   numpy                              1.22.3-py310h45f3432_0 --> 1.21.5-py37h18e8e3d_0
2022-03-11T00:27:11.4899232Z   pyopencl                           2022.1-py310hc4a4660_1 --> 2022.1-py37h1903001_1
2022-03-11T00:27:11.4899640Z   python                          3.10.2-hc74c709_4_cpython --> 3.7.12-0_73_pypy
2022-03-11T00:27:11.4900036Z   python_abi                                   3.10-2_cp310 --> 3.7-2_pypy37_pp73
2022-03-11T00:27:11.4900574Z   setuptools                         60.9.3-py310hff52083_0 --> 60.9.3-py37h9c2f6ca_0
2022-03-11T00:27:11.4900776Z 

@inducer
Copy link
Owner

inducer commented Mar 11, 2022

🤦 Nice catch!

@@ -98,7 +98,7 @@ jobs:
curl -L -O https://tiker.net/ci-support-v0
. ./ci-support-v0
build_py_project_in_conda_env
conda install matplotlib ipykernel nbconvert
pip install matplotlib ipykernel nbconvert
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pip install matplotlib ipykernel nbconvert
with_echo pip install matplotlib ipykernel nbconvert

?

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@inducer inducer disabled auto-merge March 11, 2022 01:00
@kaushikcfd
Copy link
Collaborator Author

nbconvert depending on ipython_genutils is a bit dubious: https://github.com/ipython/ipython_genutils#ipython-vestigial-utilities

@kaushikcfd
Copy link
Collaborator Author

Aah a known issue: jupyter/nbconvert#1725

@inducer
Copy link
Owner

inducer commented Mar 11, 2022

And this was the nonsense that got me started on this idiotic rabbithole:

ModuleNotFoundError: No module named 'ipython_genutils'

Turns out it's jupyter/nbconvert#1725

@inducer
Copy link
Owner

inducer commented Mar 11, 2022

Ah, yep. Got there at the same time. :)

@inducer
Copy link
Owner

inducer commented Mar 11, 2022

Added this nonsense manually for now. Grr. What a waste of time.

@inducer inducer merged commit dd1ad18 into main Mar 11, 2022
@inducer inducer deleted the make_obj_tagged_hashable branch March 11, 2022 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants