Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support more shells by shtab
The disadvantage is importing a new dependency. However, shtab can support more
shells (bash/zsh/tcsh, and fish/posh in plan), and it can provide an option
--print-completion
for user and packager to generate shell completion and fordeveloper to test, so I think it may be acceptable.
I have tested bash/zsh can work. (I don't have installed tcsh)
BTW, shtab has a bug for zsh, that is pudb3 has script_args which nargs is
argparse.REMINDER, but shtab cannot support.
I temporarily fix it in my fork and send a PR to shtab.
This is a version after fixing. You can put it directed to the correct
directory.
Result:
The test failed. However, I haven't change
pudb/var_view.py
. What happened?