-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pyopencl-like GenericScanKernel #188
base: main
Are you sure you want to change the base?
Conversation
Transplanted here for CI: https://gitlab.tiker.net/inducer/pycuda/merge_requests/11 |
|
|
Ideally, I'd like for the whole file to be identical, so that for each change I can just drop a pull request into each repo with the same file, wait for CI to pass, and move on. I don't know if that's feasible though. If not, I could be OK with the identical bits (maybe the CL/CUDA source and a base class) living in a seperate file. |
I've tried to keep the kernel source code similar to the scan kernel in
pyopencl
usingpycuda._cluda
. I am listing out the differences between the two:RESTRICT
macro to_cluda
(will make a corresponding PR topyopencl
)is_gpu
variable and the extra code that came along with it for the CPUApart from this I've added some helper functions in
pycuda.tools
, added tests forint64
dtype and a test for segmented scans that are exactly similar to those inpyopencl
and updated the documentation.