-
Notifications
You must be signed in to change notification settings - Fork 291
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement stream priority feature #321
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your contribution, and sorry about the long delay in reviewing this.
Gitlab CI link: https://gitlab.tiker.net/inducer/pycuda/-/commit/c08a582c48d1b28e201adb0b2f5a1adec1f5eef6/pipelines?ref=issue_319
Do you know how to solve this ?
I tried removing the |
Does it compile for you locally? |
Pushed to Gitlab for CI, find results via https://gitlab.tiker.net/inducer/pycuda/-/commits/issue_319 |
(Pushed once again.) |
I didn't try to do that. I usually use my CI for back and forth. I'll see if I manage to do that. |
I managed to repoduce the CI results on my machine. I think this larger message is interesting :
Looks like I can't supply two keywords with default value to this function, but I can't figure out why. Come to think of it : none of the other functions have two arguments with default values in this repo. Can you tell me how to solve this ? |
Solves #319
I'm not exactly sure my work is proper, I'm more a python guy than C++. Can you share your thoughts @inducer please ?