fix Python 3.12 builds #423
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`imp` has been removed. This updates the `get_numpy_incpath` function to use `importlib` if `imp` is not found. This preserves compatibility with ancient versions of Python3. A better solution would be to remove `imp` completely - let me know if you would prefer that.
inducer
added a commit
that referenced
this pull request
Aug 28, 2023
Includes changes equivalent to #423 Co-authored-by: Antoine Martin <antoine@xpra.org>
|
Thanks! I've applied an equivalent change (crediting you) in bf39c06. |
inducer
added a commit
to inducer/pyopencl
that referenced
this pull request
Aug 28, 2023
Includes changes equivalent to inducer/pycuda#423 Co-authored-by: Antoine Martin <antoine@xpra.org>
inducer
added a commit
to inducer/pymetis
that referenced
this pull request
Aug 28, 2023
Includes changes equivalent to inducer/pycuda#423 Co-authored-by: Antoine Martin <antoine@xpra.org>
inducer
added a commit
to inducer/meshpy
that referenced
this pull request
Aug 28, 2023
Includes changes equivalent to inducer/pycuda#423 Co-authored-by: Antoine Martin <antoine@xpra.org>
inducer
added a commit
to inducer/islpy
that referenced
this pull request
Aug 28, 2023
Includes changes equivalent to inducer/pycuda#423 Co-authored-by: Antoine Martin <antoine@xpra.org>
inducer
added a commit
to inducer/pyvisfile
that referenced
this pull request
Aug 28, 2023
Includes changes equivalent to inducer/pycuda#423 Co-authored-by: Antoine Martin <antoine@xpra.org>
|
The code you had here was a bit broken BTW: https://github.com/inducer/pyopencl/pull/699/files |
|
@inducer sorry about that - I have no idea why it worked with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
imphas been removed.This updates the
get_numpy_incpathfunction to useimportlibifimpis not found.This preserves compatibility with ancient versions of Python3. A better solution would be to remove
impcompletely - let me know if you would prefer that.