Use stream in mul_add if given and allocator in subset_sum #438
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
subset_sum(): use allocator if given.
inducer
reviewed
May 6, 2024
pycuda/gpuarray.py
Outdated
| @@ -2087,7 +2087,8 @@ def subset_sum(subset, a, dtype=None, stream=None, allocator=None): | |||
| from pycuda.reduction import get_subset_sum_kernel | |||
|
|
|||
| krnl = get_subset_sum_kernel(dtype, subset.dtype, a.dtype) | |||
| return krnl(subset, a, stream=stream) | |||
| return krnl(subset, a, stream=stream, | |||
| allocator=drv.mem_alloc if allocator is None else allocator) | |||
There was a problem hiding this comment.
This should try to get the allocator off of one of the two arrays.
There was a problem hiding this comment.
It could use a's allocator.
On the other hand, looking at other reduction functions (sum, all, any,...), they all just pass allocator to the kernel, even if it's None. So maybe we should do that here for consistency.
(I actually added the if allocator is None... by mistake - the kernel call works with allocator=None, it's only some functions like to_gpu which need a real allocator)
There was a problem hiding this comment.
Co-authored-by: Andreas Klöckner <inform@tiker.net>
inducer
approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi Andreas,
Somehow gpuarrays'
mul_adddid not use the suppliedstreamparameter. Similarly, theallocatorparameter ofsubset_sumwas not used either.This PR should fix that, and also adds an optional
outparameter tomul_add.