Switch from pybind11 to nanobind #546
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inducer
force-pushed
the
nanobind
branch
14 times, most recently
from
a51c12e to
e169e84
Compare
inducer
force-pushed
the
nanobind
branch
2 times, most recently
from
89322d0 to
076dc15
Compare
|
The infinite recursions appear to be wjakob/nanobind#72. |
inducer
force-pushed
the
nanobind
branch
4 times, most recently
from
6d7671c to
068d492
Compare
inducer
force-pushed
the
nanobind
branch
7 times, most recently
from
e3c0eaa to
189a4ee
Compare
|
@matthiasdiener FYI this is happening I think. I'll probably roll a release once it's in. |
matthiasdiener
added a commit
to matthiasdiener/pyopencl
that referenced
this pull request
May 8, 2024
inducer
pushed a commit
that referenced
this pull request
May 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Surprisingly, this is mostly working now. :)
To do/Needs:
Pass location of numpy headers to CMake(found via CMake now)Pass OpenCL config info to CMake(found via CMake now)pycl test_wrapper.py 'test_mempool(cl._csc)'crashesPYOPENCL_TEST=port python test_array.py "test_mem_pool_with_arrays(cl._csc)"crashesLetstd::stringandchar *casters also acceptbyteswjakob/nanobind#23Arithmetic type caster: fall back to casting viaPyNumber_*wjakob/nanobind#24See if the(doesn't matter for loopy enqueues, that goes straight to_enqueuetrampoline can be avoidedenqueue_nd_range_kernel)Custom exceptions wjakob/nanobind#71Wait for nanobind 2, forfor_setter.cl.Context, which nanobind doesn't currently allow. (Edit: Now does allow.)Work around Add (failing) test for(This seems to have been resolved in the meantime.)__eq__-in-baseclass wjakob/nanobind#72