Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

choose_devices: don't short-circuit dev choice when answers available #780

Merged
merged 4 commits into from
Aug 28, 2024

Conversation

matthiasdiener
Copy link
Contributor

@matthiasdiener matthiasdiener commented Aug 26, 2024

Otherwise, spurious errors can occur:

# only single device available on this platform:

$ clinfo -l
Platform #0: AMD Accelerated Parallel Processing
 `-- Device #0: gfx90a:sramecc+:xnack-  
$ PYOPENCL_CTX=AMD:0 python -c "import pyopencl; pyopencl.choose_devices()"
Traceback (most recent call last):
  File "<string>", line 1, in <module>
  File "/p/lustre1/diener3/Work/enew/pyopencl/pyopencl/__init__.py", line 1674, in choose_devices
    raise RuntimeError("not all provided choices were used by "
pyopencl._cl.RuntimeError: not all provided choices were used by choose_devices. (left over: '0')

PYOPENCL_TEST=AMD:0 works fine in this context.

See also #781.

Please squash

@inducer inducer merged commit fec3ef6 into inducer:main Aug 28, 2024
17 checks passed
@matthiasdiener matthiasdiener deleted the choose-dev-answer branch October 4, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants