Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow reshapes for 'F' ordered arrays #455

Merged
merged 31 commits into from
Sep 9, 2024

Conversation

a-alveyblanc
Copy link
Contributor

  • Add case for 'F' ordered arrays in _get_reshaped_indices
  • Remove requirements that arrays must be 'C' ordered

@a-alveyblanc a-alveyblanc changed the title First shot at implementing 'F' ordered array reshapes Allow reshapes for 'F' ordered arrays Sep 11, 2023
@inducer
Copy link
Owner

inducer commented Sep 11, 2023

There seem to be some merge conflicts.

@inducer
Copy link
Owner

inducer commented Sep 11, 2023

Remove requirements that arrays must be 'C' ordered

Note that the order argument in reshape has nothing to do with in-memory ordering of the array. Pytato arrays do not have a defined in-memory ordering, FWIW.

pytato/array.py Outdated Show resolved Hide resolved
pytato/transform/lower_to_index_lambda.py Outdated Show resolved Hide resolved
pytato/transform/lower_to_index_lambda.py Outdated Show resolved Hide resolved
pytato/transform/lower_to_index_lambda.py Outdated Show resolved Hide resolved
@inducer
Copy link
Owner

inducer commented Sep 11, 2023

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

@a-alveyblanc
Copy link
Contributor Author

@inducer This is ready for another look

@inducer
Copy link
Owner

inducer commented Mar 30, 2024

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

@a-alveyblanc
Copy link
Contributor Author

@inducer This is ready for another look.

If it seems like there's still a fair amount of work to be done on the updated index computation (i.e. leaving unchanged axes alone), maybe we should consider moving that work to another branch in favor of getting F-ordered reshapes merged.

@inducer inducer enabled auto-merge (squash) September 9, 2024 17:04
@inducer inducer merged commit 2de3bc9 into inducer:main Sep 9, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants