Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

replace immutables.Map with immutabledict #461

Merged
merged 2 commits into from
Oct 6, 2023
Merged

replace immutables.Map with immutabledict #461

merged 2 commits into from
Oct 6, 2023

Conversation

matthiasdiener
Copy link
Collaborator

@matthiasdiener matthiasdiener commented Oct 5, 2023 •
edited
Loading

Based on #457 (comment), immutabledict has a consistent iteration order (like dict, i.e. insertion order), and is likely faster than immutables.Map, especially for actually immutable dicts (see also the graph here).

@matthiasdiener matthiasdiener self-assigned this Oct 5, 2023
@matthiasdiener matthiasdiener requested a review from inducer October 5, 2023 23:58
@matthiasdiener matthiasdiener marked this pull request as ready for review October 5, 2023 23:58
@inducer inducer enabled auto-merge (squash) October 6, 2023 03:44
@inducer
Copy link
Owner

inducer commented Oct 6, 2023

Thanks!

@inducer inducer merged commit 6adf9ae into main Oct 6, 2023
9 checks passed
@inducer inducer deleted the immutabledict branch October 6, 2023 04:02
@majosm majosm mentioned this pull request May 7, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inducer inducer Awaiting requested review from inducer

Assignees

@matthiasdiener matthiasdiener

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matthiasdiener @inducer