make MPI tags deterministic #462
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matthiasdiener
force-pushed
the
deterministic-mpi_tag
branch
from
989d3cd to
0490f10
Compare
matthiasdiener
changed the title
inducer
reviewed
Oct 19, 2023
| @@ -99,7 +99,7 @@ def set_union( | |||
| next_tag = base_tag | |||
| assert isinstance(all_tags, frozenset) | |||
|
|
|||
| for sym_tag in all_tags: | |||
| for sym_tag in sorted(all_tags): | |||
There was a problem hiding this comment.
Are they necessarily ordered? What are we sorting by?
matthiasdiener
force-pushed
the
deterministic-mpi_tag
branch
from
0490f10 to
f2650b8
Compare
inducer
force-pushed
the
deterministic-mpi_tag
branch
from
7e175bc to
eac1bd7
Compare
|
Pushed some minor stuff, LGTM. Thanks! |
This was referenced Nov 9, 2023
inducer
added a commit
that referenced
this pull request
Nov 13, 2023
Co-authored-by: Andreas Kloeckner <inform@tiker.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This requires tags to be sortable. The only other option I can see is to use some kind of ordered set type.