-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deterministic find_distributed_partition (non-set) #529
Open
matthiasdiener
wants to merge
36
commits into
main
Choose a base branch
from
deterministic-fdp-nonset
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
3364a4f
working pass 1
matthiasdiener ef7ea0b
cleanups
matthiasdiener 817b255
enable determinism test
matthiasdiener f3f3c7d
eliminate _OrderedSets
matthiasdiener 8bf2daf
misc improvements
matthiasdiener 5d906b5
revert change to SubsetDependencyMapper
matthiasdiener 142c8e6
some mypy fixes
matthiasdiener 4e0e174
Merge branch 'main' into deterministic-fdp-nonset
matthiasdiener bd70620
ruff
matthiasdiener 076a76e
replace orderedsets with unique tuples in DirectPredecessorsGetter
matthiasdiener ea1462c
mypy fixes
matthiasdiener 168ef53
remove unnecesary cast
matthiasdiener d711989
adjust comment
matthiasdiener c976c23
Merge branch 'main' into deterministic-fdp-nonset
matthiasdiener fde8f77
Merge branch 'main' into deterministic-fdp-nonset
matthiasdiener 7e03b35
Merge branch 'main' into deterministic-fdp-nonset
matthiasdiener 5847800
performance fix
matthiasdiener 7dd83bb
switch to dicts
matthiasdiener 1ea962c
more dict usage
matthiasdiener 77f1bbd
Merge branch 'main' into deterministic-fdp-nonset
matthiasdiener e8b5806
fix materialized_arrays perf
matthiasdiener 4a9f9f5
Merge branch 'main' into deterministic-fdp-nonset
matthiasdiener 12e9449
Merge branch 'main' into deterministic-fdp-nonset
matthiasdiener 7050bc8
Merge branch 'main' into deterministic-fdp-nonset
inducer 94658af
Fix imports
inducer 535539e
Merge branch 'main' into deterministic-fdp-nonset
inducer 3cac91f
Merge branch 'main' into deterministic-fdp-nonset
matthiasdiener 8929bed
Merge branch 'main' into deterministic-fdp-nonset
matthiasdiener 3a30e88
ruff
matthiasdiener 0124792
Merge branch 'main' into deterministic-fdp-nonset
inducer 25ce81e
Merge branch 'main' into deterministic-fdp-nonset
matthiasdiener 3530b53
use operator.or_ in reduction
matthiasdiener fbcbcef
use a FakeOrderedFrozenSet type
matthiasdiener bc87f3a
extend FakeOrderedSet typing
matthiasdiener fa1f6f1
Merge branch 'main' into deterministic-fdp-nonset
matthiasdiener 4424a2e
ruff
matthiasdiener File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wasn't able to get this to work with mypy, but what do you think of fbcbcef?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That works for me. I was under the impression that type aliases could not be generic, but apparently I'm wrong? I tried for a bit to back up my assumption, but I wasn't able to. (I also wasn't able to back up the opposite.) Definitive info would be most welcome! 🙂
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe this is related? https://mypy.readthedocs.io/en/stable/generics.html#generic-type-aliases