Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow get_reachable_nodes to be restricted to partitions #278

Merged
merged 3 commits into from
Dec 12, 2024

Conversation

a-alveyblanc
Copy link
Contributor

@a-alveyblanc a-alveyblanc commented Dec 11, 2024

Updates get_reachable_nodes to take an optional set containing nodes that should be ignored (effectively partition points) in an undirected graph. Also updates the corresponding test to account for this new feature.

@inducer inducer force-pushed the get-reachable-nodes-update branch from 5fe44f4 to 0c7b929 Compare December 12, 2024 17:52
Copy link
Owner

@inducer inducer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Some comments below.

pytools/graph.py Outdated Show resolved Hide resolved
pytools/graph.py Outdated Show resolved Hide resolved
pytools/graph.py Outdated Show resolved Hide resolved
pytools/graph.py Outdated Show resolved Hide resolved
pytools/graph.py Outdated Show resolved Hide resolved
@inducer
Copy link
Owner

inducer commented Dec 12, 2024

Btw: I rebased out the fixes for RUF052. I campaigned to get function arguments removed from that rule, and a new ruff with that change got released today--so we were just waiting that out.

@inducer
Copy link
Owner

inducer commented Dec 12, 2024

Unsubscribing... @-mention or request review once it's ready for a look or needs attention.

@a-alveyblanc
Copy link
Contributor Author

Ready for another look, @inducer

@inducer inducer merged commit 37e34d1 into inducer:main Dec 12, 2024
17 checks passed
@inducer
Copy link
Owner

inducer commented Dec 12, 2024

I'll roll a release once #279 is in.

@inducer
Copy link
Owner

inducer commented Dec 13, 2024

https://pypi.org/project/pytools/2024.1.21/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants