Compatibility with python3 and airflow 1.9 #17
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
First - thanks for this excellent library. We're using it to do some stuff that's otherwise very hard in Airflow.
We're going to be upgrading our codebase to airflow 1.9 and python 3.6.1, so I've made some changes to allow compatibility with both.
Changes as follows:
PythonOperator
to satisfy its check for acallable
DiveOperator
to stop the deprecation warning that airflow emits.I've made various edits to the unit tests since implicit bytes == str comparisons will fail under python3. Mostly this has just been passing explicit
encoding='utf-8'
arguments to the variousas_string
methods. I notice that the core library is careful to do this anyway.All tests are passing in python2.7.13 and python3.6.1.