Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add .npmignore files to avoid packaging unneeded files #75

Closed
wants to merge 1 commit into from

Conversation

marco-c
Copy link
Contributor

@marco-c marco-c commented Aug 30, 2016

The main package shouldn't need to include the tests and the packages under rfc/.
The rfc packages only need not to include the tests.

@fanatid
Copy link

fanatid commented Aug 30, 2016

@marco-c OOI, why you added rfc/2560/.npmignore and rfc/5280/.npmignore? rfc in main .npmignore not work?

@marco-c
Copy link
Contributor Author

marco-c commented Aug 30, 2016

@fanatid they are separate packages, they're published separately from the main package.

@fanatid
Copy link

fanatid commented Aug 30, 2016

oh, really, sorry..

indutny pushed a commit that referenced this pull request Sep 19, 2016
PR-URL: #75
Reviewed-By: Fedor Indutny <fedor@indutny.com>
@indutny
Copy link
Owner

indutny commented Sep 19, 2016

Landed in c5babea, sorry for delay!

@indutny indutny closed this Sep 19, 2016
@marco-c
Copy link
Contributor Author

marco-c commented Sep 19, 2016

Could you publish a new minor release?

@marco-c marco-c deleted the npmignore branch September 19, 2016 21:05
@indutny
Copy link
Owner

indutny commented Sep 19, 2016

Done!

@marco-c
Copy link
Contributor Author

marco-c commented Sep 19, 2016

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants