Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: fix for negative numbers: imuln, modrn, idivn #185

Merged
merged 1 commit into from
Jun 18, 2018
Merged

lib: fix for negative numbers: imuln, modrn, idivn #185

merged 1 commit into from
Jun 18, 2018

Conversation

fanatid
Copy link
Collaborator

@fanatid fanatid commented May 28, 2018

No description provided.

@fanatid
Copy link
Collaborator Author

fanatid commented May 28, 2018

@indutny can you review, merge and release? :)

@dcousens dcousens added the bug label Jun 6, 2018
dcousens
dcousens approved these changes Jun 6, 2018
View reviewed changes
Copy link
Contributor

@dcousens dcousens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but, is there any more tests we could add to cover this?

@fanatid
Copy link
Collaborator Author

fanatid commented Jun 15, 2018

@dcousens are we waiting more tests from me? :)

@dcousens
Copy link
Contributor

dcousens commented Jun 16, 2018 •
edited
Loading

@fanatid aye, I was asking, it seems important to only cover with 1 test...
Could you maybe test the other functions too?

@fanatid fanatid changed the title lib: fix BN#imuln for negative numbers lib: fix for negative numbers: imuln, modrn, idivn Jun 17, 2018
@fanatid
Copy link
Collaborator Author

fanatid commented Jun 17, 2018

@dcousens additionally fixed modrn, idivn

@dcousens
Copy link
Contributor

@indutny LGTM, can you ACK?

indutny
indutny approved these changes Jun 17, 2018
View reviewed changes
Copy link
Owner

@indutny indutny left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dcousens dcousens merged commit e69c617 into indutny:master Jun 18, 2018
@fanatid fanatid deleted the fix/imuln branch June 18, 2018 06:09
@fanatid
Copy link
Collaborator Author

fanatid commented Jun 18, 2018

Thanks. Can you publish new version? (This is not only one change what was introduced from last version)

@fanatid fanatid mentioned this pull request Dec 23, 2019
Closed
@meck93 meck93 mentioned this pull request Jan 24, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@indutny indutny indutny approved these changes

@dcousens dcousens dcousens approved these changes

Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fanatid @dcousens @indutny