Fix BN v5/v4 interoperability issue for v5.x #249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
That's indeed strange. 😕 Maybe just do the fix yourself directly on the main repo, don't have to retain me as the author or something. |
holgerd77
force-pushed
the
v5.x-fix-bn-v5-v4-interoperability-issue
branch
from
ee15418
to
d30ba22
Compare
|
Ah no, did another short test (changing the code comments a little), didn't work. Anyhow. |
|
CI: Looks like not only we have problem with it: https://github.saobby.my.eu.orgmunity/t5/GitHub-Actions/Github-action-stuck-at-queue/td-p/38003/page/6 |
|
👍 |
|
Published as |
|
Ok, I re-added the browser tests I commented out before on the wallet library PR ethereumjs/ethereumjs-wallet#121, if |
|
Ok, can confirm, browser tests ran through. |
This was referenced Aug 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #239 on the 5.x branch
Made sure that the respective code part is actually touched by the unit tests.
(second try following #247 after CI problems)