win: try to find VS2017 tooling #30
Conversation
|
@indutny review? |
refack
force-pushed
the
detect-vs2017
branch
2 times, most recently
from
142b10b to
f218e76
Compare
|
@indutny BTW don't give up on this project! |
indutny
left a comment
indutny
left a comment
There was a problem hiding this comment.
What is a Setup.Configuration.exe file about? Where did it come from, is it possible to just use command-line tools provided with the system?
lib/gyp/platform/win.js
Outdated
| const envFile = 'environment.' + arch; | ||
| fs.writeFileSync(path.join(outDir, envFile), envBlock); | ||
| return envFile; | ||
|
|
test/platform-win-test.js
Outdated
| assert.deepEqual( | ||
| win.adjustLibraries([ '-llib1.lib', 'lib2.lib' ]), | ||
| [ 'lib1.lib', 'lib2.lib' ]); | ||
| win.adjustLibraries(['-llib1.lib', 'lib2.lib']), |
refack
force-pushed
the
detect-vs2017
branch
2 times, most recently
from
124dbc1 to
51d2ad9
Compare
|
So the "Setup.Configuration.exe" tools comes from Microsoft's recomanded way to find visual studio components actualy this repos, self compiled. It's a tiny tools that just calls a COM server, and obviously only works when VS2017 is installed but fails gracefully. P.S. White space changes were reverted. |
|
@refack I have very mixed feelings about distributing |
|
I totally get what you're saying, I'll dig in more... |
|
Thank you! I appreciate your effort!
…On Thu, Feb 2, 2017 at 21:22 Refael Ackermann ***@***.***> wrote:
I totally get what you're saying, I'll dig in more...
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#30 (comment)>, or mute
the thread
<https://github.com/notifications/unsubscribe-auth/AAOjw7aqR3jEl3V4v0Vr1S-Y85ux2Ndfks5rYo9fgaJpZM4Lf_hA>
.
|
|
Given that this indeed speaks to COM, I'm not sure if there is any easier way to do it without having either What do you think? |
|
There is a way to talk to COM via Give me the rest of the day... |
|
Sure! Thanks! |
Using the MS recommended way (COM call)* Work with all flavors of VS2017, even the minimal "C++ Build Tools" *https://blogs.msdn.microsoft.com/heaths/2016/09/15/changes-to-visual-studio-15-setup/
|
Cracked it! 🥇 |
|
made obsolete by #33 |
2 participants
Using the MS recommended way of looking in the registry
Work with all flavors of VS2017, even the minimal "C++ Build Tools"
(obviously
npm run testpasses)