Error on Node 18

[riovir]

The address() function uses os.networkInterfaces(). A currently undocumented change in Node 18 resulted in the type of defails.family becoming a number.

Naturally, calling .toLowerCase() on the number throws an error.

[Apollon77]

see also nodejs/node#41431 (review)

[jaiswarvipin]

Found issue in the "ip.js" code where family variable value coming in value.

fix

On line 386 do following change

if(!isNaN(details.family)){
        details.family = ((details.family == 4)?"ipv4":"ipv6");
      }
      details.family = details.family.toLowerCase();

[Apollon77]

@jaiswarvipin The fix is easy ... The problem is that this library is used in many others, so it would need new versions of this lib with the fix to be really useful

[jaiswarvipin]

noted.

Currently not able to create / check-in as separate branch with new version, its giving access denied.

warning: ΓöîΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇ SECURITY WARNING ΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÉ
warning: Γöé TLS certificate verification has been disabled! Γöé
warning: ΓööΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÿ
warning: HTTPS connections may not be secure. See https://aka.ms/gcmcore-tlsverify for more information.
info: please complete authentication in your browser...
warning: ΓöîΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇ SECURITY WARNING ΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÉ
warning: Γöé TLS certificate verification has been disabled! Γöé
warning: ΓööΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÇΓöÿ
warning: HTTPS connections may not be secure. See https://aka.ms/gcmcore-tlsverify for more information.
remote: Permission to indutny/node-ip.git denied to jaiswarvipin.
fatal: unable to access 'https://github.com/indutny/node-ip.git/': The requested URL returned error: 403

[jaiswarvipin]

Proposed fix for IPV4 and IPv6 (Single m/c/ Scale set, Kubernetes, Mobile Device) working as expected. Kindly merge the code base in main branch

[megaandros]

The issue can be fixed with node.js = v.17.9.0
How to downgrade - https://stackoverflow.com/questions/58280757/how-to-upgrade-node-to-specific-version-in-macos-mojave-and-update-the-active-p

[sjoqvist]

@megaandros You're correct that it's a workaround, but I'd argue that downgrading to Node 17 isn't a proper fix to "Error on Node 18".

It should also be noted that Node 17 goes end-of-life on June 1, i.e. in just 29 days.

[indutny]

This should be fixed in the latest release. Sorry it took me so long to get to it.

[Apollon77]

Thank you very much(indeed ... the nodejs guys discuss reverting this breaking change btw ;-)))) ... but still anything ok with how you fixed it