Hosts & Accessible Server Instance (and tests) #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
While net.Server supports defining a host, Master did not. Now it does.
Support host definiton within options
Feature: The server instance, with .address() function etc is passed back on master(old: master=false worker=true, new: master=serverInstance, worker=false) - this only happens if you set options.returnInstance to true, otherwise it is 'classis style'. Existing tests have been updated to manage async issues. 2 new tests (for the 2 new features) have been added. test.sh added to run all the tests synchronously
|
Is this repo no longer maintained? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature: Host can be set in options.
Feature: The server instance, with .address() function etc is passed back on master(old: master=false worker=true, new: master=serverInstance, worker=false) - this only happens if you set options.returnInstance to true, otherwise it is 'classis style'.
Existing tests have been updated to manage async issues.
2 new tests (for the 2 new features) have been added.