Fix more review comments.

indygreg · Dec 18, 2022 · 56be683 · 56be683
1 parent f44ed8c
commit 56be683
Show file tree

Hide file tree

Showing 8 changed files with 71 additions and 171 deletions.
diff --git a/app-store-connect/src/bundle_api.rs b/app-store-connect/src/bundle_api.rs
@@ -84,7 +84,7 @@ pub struct BundleIdCreateRequestAttributes {
     pub platform: String,
 }
 
-#[derive(Clone, Copy, Debug, Eq, PartialEq)]
+#[derive(Clone, Copy, Debug, Eq, PartialEq, clap::ValueEnum)]
 pub enum BundleIdPlatform {
     Ios,
     MacOs,

diff --git a/app-store-connect/src/certs_api.rs b/app-store-connect/src/certs_api.rs
@@ -14,7 +14,7 @@ use std::io::Write;
 use std::path::Path;
 use x509_certificate::{InMemorySigningKeyPair, Sign, X509CertificateBuilder};
 
-pub fn generate_key(api_key: &Path, ty: CertificateType, pem: &Path) -> Result<()> {
+pub fn generate_signing_certificate(api_key: &Path, ty: CertificateType, pem: &Path) -> Result<()> {
     let secret = RsaPrivateKey::new(&mut OsRng, 2048)?;
     let key = InMemorySigningKeyPair::from_pkcs8_der(secret.to_pkcs8_der()?.as_bytes())?;
     let mut builder = X509CertificateBuilder::new(key.key_algorithm().unwrap());
@@ -119,7 +119,7 @@ pub struct CertificateCreateRequestAttributes {
     pub csr_content: String,
 }
 
-#[derive(Clone, Copy, Debug, Eq, PartialEq)]
+#[derive(Clone, Copy, Debug, Eq, PartialEq, clap::ValueEnum)]
 pub enum CertificateType {
     Development,
     Distribution,