feat: implement optional reqwest depdendency for smaller deps #21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 26, 2024
indygreg
approved these changes
Nov 2, 2024
indygreg
pushed a commit
that referenced
this pull request
Nov 2, 2024
This slims down the dependency tree significantly if the feature is disabled. Closes #21.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in #9, I've gone ahead and declared
reqwestan optional dependency using features. By default, I've kept it as a dependency and users can opt out of using it and installing the dependencies by declaringdefault-featuresfalse.cryptographic-message-syntax = { version = "0.26.0", default-features = false }