Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add randomly generated user agents #42

Merged
merged 3 commits into from
Nov 29, 2022

Conversation

muppet3000
Copy link
Contributor

@muppet3000 muppet3000 commented Nov 22, 2022

Added an alternative solution to #40

@muppet3000
Copy link
Contributor Author

Note - Once we agree on an implementation I'd like to update the documentation before it's merged, there's no point me doing that before the decision is made though

@indykoning
Copy link
Owner

It's looking good to me! We can still request without problems using this? 🙂

@muppet3000
Copy link
Contributor Author

It's looking good to me! We can still request without problems using this? 🙂

😄 Yeah it still works!
I've emailed every possible support address I can find for Growatt asking them to collaborate with us, so I'm hoping they come back eventually!

@muppet3000
Copy link
Contributor Author

I've now added the documentation & an example with all the options and it even validates that it works.

I've changed the logic slightly so that it matches the way the server_url is stored, it also means that you can access the default value if you want to extend it and pass it back in (see my examples).

@indykoning
Copy link
Owner

Looks good! I'll merge this as 1.3.0 🎉

@indykoning indykoning changed the title Added random-number option to User-Agent and allowed users to specify their own when library is initialised Add randomly generated user agents Nov 29, 2022
@indykoning indykoning merged commit 2621367 into indykoning:master Nov 29, 2022
@Sjord Sjord mentioned this pull request Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants